Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip-files-fetch option #166

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

marmarek
Copy link
Member

It's useful to fetch just git repos, but not distfiles. It's useful when
fetching all repositories, but fetching actual files only when building.
Especially saves a lot of space from kernel tarballs.

And also, useful when using builder just to verify sources.

QubesOS/qubes-issues#9662

@marmarek marmarek force-pushed the skip-fetch-files branch 3 times, most recently from 7bf7a38 to fccd522 Compare December 20, 2024 21:05
It's useful to fetch just git repos, but not distfiles. It's useful when
fetching all repositories, but fetching actual files only when building.
Especially saves a lot of space from kernel tarballs.

And also, useful when using builder just to verify sources.

QubesOS/qubes-issues#9662
Do not override the whole env, just add/replace GNUPGHOME env. This is
especially for subprocess to find git or gpg using PATH variable.
And also use /usr/bin/env python3 in shebang (similarly to the main
qubesbuilder-cli script), do not assume /usr/bin/python3.
If there is no need to use sudo (most of the cases), don't try it. This
avoids polluting logs if sudo is not allowed, or even not installed.
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.28%. Comparing base (b1e68ec) to head (a8d4ec8).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
qubesbuilder/executors/local.py 25.00% 3 Missing ⚠️
qubesbuilder/plugins/fetch/__init__.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   78.62%   78.28%   -0.35%     
==========================================
  Files          47       47              
  Lines        5400     5407       +7     
==========================================
- Hits         4246     4233      -13     
- Misses       1154     1174      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

There is --git-commit option for get-and-verify-source.py already. Use
its implementation, but keep verifying tags. For that, they need to be
fetched.
Scheduled pipelines on the "main" branch have cache jobs enabled, and
those jobs are used by more or less all pipelines in other repos for
quicker run.
Do this for ordinary "main" pipelines too, otherwise all jobs won't use
a cache for a week after merging anything to the builderv2 repo.
@marmarek marmarek requested a review from fepitre January 6, 2025 15:13
@marmarek marmarek merged commit e0321e2 into QubesOS:main Jan 10, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants